Removing Mass Ratio of Water to Dry Matter units from concentration #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While these units are types of concentration, they're conditional to the medium of the dry matter in order to do conversions from the standrd unit of parts:parts. So removing while they're unused. If we want to reintroduce them, we should ensure that it belongs under concentration as opposed to redefining massconcentration
cstirdivant
added
the
breaking_change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While these units are types of concentration, they're conditional to the medium of the dry matter in order to do conversions from the standard unit of parts:parts. So removing while they're unused. If we want to reintroduce them, we should ensure that it belongs under concentration as opposed to redefining massconcentration
This change is not fully backwards compatible so will need land with grace.