Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water/Steam Valve Voltage Monitoring #1454

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Water/Steam Valve Voltage Monitoring #1454

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
fc6d328
Update telemetry_fields.yaml
pranay2811 Oct 25, 2024
c91b6eb
Added BYPVVM
pranay2811 Oct 25, 2024
46106c1
Added CHWVVM
pranay2811 Oct 25, 2024
420127a
Added HXSWISOVVM
pranay2811 Oct 25, 2024
233fb1f
Added HWVVM
pranay2811 Oct 25, 2024
6cbdbd7
Added MWVVM
pranay2811 Oct 25, 2024
0f880c6
Added PHWVVSC
pranay2811 Oct 25, 2024
343e11a
Added SVVM
pranay2811 Oct 25, 2024
4495db4
Merge branch 'master' into valve-voltage
pranay2811 Oct 25, 2024
c7ceddf
Update max values to 120.0
pranay2811 Oct 31, 2024
836dee5
Updated CHWVVM - made sensor required field
pranay2811 Oct 31, 2024
fdc41fc
Correction in HWVVM
pranay2811 Nov 4, 2024
28ef433
Added makeup_water_valve_voltage_sensor
pranay2811 Nov 4, 2024
627f8e4
Updated MWVVM
pranay2811 Nov 4, 2024
8782417
Updated CHWVVM
pranay2811 Nov 4, 2024
3e63db1
Added steam_valve_voltage_sensor
pranay2811 Nov 4, 2024
97707f0
Updated SVVM
pranay2811 Nov 4, 2024
075eda5
Merge branch 'master' into valve-voltage
pranay2811 Nov 4, 2024
f8372f6
Updated HWVVM & BYPVVM
pranay2811 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 79 additions & 2 deletions ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3353,6 +3353,23 @@ HWRWC:
implements:
- CONTROL

PHWVVSC:
guid: "b1fecf41-bedf-48e6-9e8c-ab0705c4c6d2"
description: "Preheating water valve voltage monitoring on supply air side."
is_abstract: true
opt_uses:
- heating_request_count
- leaving_air_preheating_coil_temperature_sensor
- high_supply_air_temperature_alarm
- low_supply_air_temperature_alarm
- preheating_run_command
uses:
- preheating_water_valve_voltage_command
shambergoldstein marked this conversation as resolved.
Show resolved Hide resolved
- supply_air_temperature_sensor
- supply_air_temperature_setpoint
implements:
- CONTROL

PHWSC:
guid: "0f2f9a53-6aab-4c9c-801f-bb11b021e42a"
description: "Preheating water valve control on supply air side."
Expand Down Expand Up @@ -4194,6 +4211,17 @@ BYPVPM:
implements:
- MONITORING

BYPVVM:
guid: "043e2922-f9df-4442-9bc0-b1e68eb41008"
description: "Bypass water valve voltage monitoring."
is_abstract: true
opt_uses:
- bypass_valve_voltage_sensor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the sensor required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shambergoldstein Done

- failed_bypass_valve_alarm
uses:
- bypass_valve_voltage_command
implements:
- MONITORING

MWVPM:
guid: "bd83e820-585d-4e03-9142-7d4355b41574"
Expand All @@ -4203,7 +4231,16 @@ MWVPM:
- makeup_water_valve_percentage_command
implements:
- MONITORING


MWVVM:
guid: "0e4215df-3401-4cf0-bdfe-9e03d6c69a48"
description: "Make-up water valve voltage monitoring."
is_abstract: true
uses:
- makeup_water_valve_voltage_command
shambergoldstein marked this conversation as resolved.
Show resolved Hide resolved
- makeup_water_valve_voltage_sensor
implements:
- MONITORING

HXSWISOVPM:
guid: "04a7805d-e8ff-4b53-9513-d88ede4635ff"
Expand All @@ -4215,6 +4252,15 @@ HXSWISOVPM:
implements:
- MONITORING

HXSWISOVVM:
guid: "f1c95b51-7b96-4bf9-a4e4-b47e72f9834f"
description: "Heat exchanger supply isolation water valve voltage monitoring."
is_abstract: true
uses:
- heat_exchange_supply_water_isolation_valve_voltage_command
- heat_exchange_supply_water_isolation_valve_voltage_sensor
implements:
- MONITORING

HXRWISOVPM:
guid: "789cd63d-8168-43fe-9245-c54a8527482c"
Expand Down Expand Up @@ -5486,6 +5532,17 @@ HWVM:
implements:
- OPERATIONAL

HWVVM:
guid: "3e193668-77e3-454e-9153-fdc3475d9012"
description: "Heating water valve voltage monitoring."
is_abstract: true
opt_uses:
- heating_water_flowrate_sensor
- heating_water_valve_voltage_sensor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the sensor required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shambergoldstein Done

uses:
- heating_water_valve_voltage_command
implements:
- OPERATIONAL

CHWVM:
guid: "73411f3e-5c42-40cb-8d6c-82f1e2358844"
Expand All @@ -5502,7 +5559,19 @@ CHWVM:
implements:
- OPERATIONAL


CHWVVM:
guid: "cd1be55d-85bc-4e0b-82b0-f3e38c427521"
description: "Chilled water valve voltage monitoring."
is_abstract: true
opt_uses:
- chilled_water_flowrate_sensor
- failed_chilled_water_valve_alarm
uses:
- chilled_water_valve_voltage_command
- chilled_water_valve_voltage_sensor
implements:
- OPERATIONAL

RMM:
guid: "162df361-7593-4e36-bf41-e7fa667244dd"
description: "Run mode monitoring."
Expand Down Expand Up @@ -8488,6 +8557,14 @@ FPHC:
- heating_water_valve_percentage_command
- chilled_water_valve_percentage_command

SVVM:
guid: "9b702772-2303-4648-bc88-4f23d97c0349"
description: "Steam valve voltage monitoring."
is_abstract: true
uses:
- steam_valve_voltage_command
shambergoldstein marked this conversation as resolved.
Show resolved Hide resolved
- steam_valve_voltage_sensor

SSTC:
guid: "3aefe568-b8eb-485e-a3d9-38ac3bb9906d"
description: "Supply steam valve monitoring to control water temperature on supply side for steam exchanger."
Expand Down
40 changes: 40 additions & 0 deletions ontology/yaml/resources/fields/telemetry_fields.yaml
View file
Open in desktop
shambergoldstein marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -3929,6 +3929,45 @@ literals:
- heating_return_water_pressure_sensor:
flexible_min: -34473.78945
flexible_max: 344737.8945
- bypass_valve_voltage_command:
flexible_min: 0.0
flexible_max: 120.0
- bypass_valve_voltage_sensor:
flexible_min: 0.0
flexible_max: 120.0
- chilled_water_valve_voltage_command:
flexible_min: 0.0
flexible_max: 120.0
- chilled_water_valve_voltage_sensor:
flexible_min: 0.0
flexible_max: 120.0
- heat_exchange_supply_water_isolation_valve_voltage_command:
flexible_min: 0.0
flexible_max: 120.0
- heat_exchange_supply_water_isolation_valve_voltage_sensor:
flexible_min: 0.0
flexible_max: 120.0
- heating_water_valve_voltage_command:
flexible_min: 0.0
flexible_max: 120.0
- heating_water_valve_voltage_sensor:
flexible_min: 0.0
flexible_max: 120.0
- makeup_water_valve_voltage_command:
flexible_min: 0.0
flexible_max: 120.0
- makeup_water_valve_voltage_sensor:
flexible_min: 0.0
flexible_max: 120.0
- preheating_water_valve_voltage_command:
flexible_min: 0.0
flexible_max: 120.0
- steam_valve_voltage_command:
flexible_min: 0.0
flexible_max: 120.0
- steam_valve_voltage_sensor:
flexible_min: 0.0
flexible_max: 120.0
- exhaust_air_relative_humidity_sensor:
fixed_min: 0.0
fixed_max: 100.0
Expand All @@ -3950,3 +3989,4 @@ literals:
- supply_glycol_temperature_setpoint:
flexible_min: 255.9259259
flexible_max: 380.3703704