Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create data transmitting class for fgviewer #8332

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

show50726
Copy link
Contributor

  • Add FrameGraphInfo class for transmitting data between the engine and the server
  • Adjust DebugServer api to align with the design
    • Has an unique handle to track the views instead of hashing the view name as the key, since the view name is not guaranteed to be unique

@show50726 show50726 added the internal Issue/PR does not affect clients label Jan 1, 2025
libs/fgviewer/include/fgviewer/FrameGraphInfo.h Outdated Show resolved Hide resolved
libs/fgviewer/include/fgviewer/DebugServer.h Outdated Show resolved Hide resolved
libs/fgviewer/include/fgviewer/FrameGraphInfo.h Outdated Show resolved Hide resolved
@poweifeng
Copy link
Contributor

Sorry I had one more comment that somehow got lost in the shuffle.

Your code has a lot of definitions of this form:

void func(Object copy) {
  value = std::move(copy);
}

I think typically

void func(const Object& obj) {
  value = obj; // actual copy
}

is equivalent and more common.

Or if you're transferring content ownership, then

void func(Object&& obj) {
  value = std::move(obj);
}

is the common pattern.

Any particular reason for choosing that pattern?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants