-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow metadata pass-through in flax.struct.field #4056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change! Can we have a test for this?
ecd099e
to
62b15bf
Compare
@IvyZX Pushed a test, let me know if anything else is needed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4056 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 106 107 +1
Lines 13582 13824 +242
======================================
- Misses 13582 13824 +242 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Approved. You would need to pull and rebase for a trivial merge conflict.
@IvyZX Fixed. |
@IvyZX Are we awaiting some automated process to get this merged? |
@IvyZX Is this good for merging? |
What does this PR do?
Allows passing through
metadata
when creating aflax.struct.field
. This is useful when you want to add some metadata to your field to be read later.Checklist
checks if that's the case).
discussion (please add a
link).
documentation guidelines.
(No quality testing = no merge!)