-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Handling for urlConnection #2902
base: master
Are you sure you want to change the base?
Error Handling for urlConnection #2902
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2902 +/- ##
============================================
- Coverage 63.55% 63.45% -0.11%
- Complexity 1242 1243 +1
============================================
Files 267 267
Lines 6506 6523 +17
Branches 911 915 +4
============================================
+ Hits 4135 4139 +4
- Misses 1785 1795 +10
- Partials 586 589 +3
|
ground/src/main/java/com/google/android/ground/ui/map/gms/mog/UrlInputStream.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/ui/map/gms/mog/UrlInputStream.kt
Outdated
Show resolved
Hide resolved
We should handle the error upstream where it can actually be addressed: Lines 100 to 113 in 9ef90ad
You would add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few requests, LG
...main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorViewModel.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorFragment.kt
Show resolved
Hide resolved
...main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorViewModel.kt
Show resolved
Hide resolved
…-timeout-exception' into anandwana001/2683/prevent-socket-timeout-exception
Fixes #2683
@shobhitagarwal1612 PTAL?