[WIP] Integrate TaskSequenceHandler with DataCollectionViewModel #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ground/src/main/java/com/google/android/ground/ui/datacollection/TaskSequenceHandler.kt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2986 +/- ##
============================================
- Coverage 63.43% 63.32% -0.12%
+ Complexity 1259 1248 -11
============================================
Files 269 269
Lines 6548 6525 -23
Branches 927 924 -3
============================================
- Hits 4154 4132 -22
+ Misses 1793 1791 -2
- Partials 601 602 +1
|
|
Let's hold this one until the latest release candidate is cut. |
|
The problem with current existing and proposed is that we aren't caching the value of sequence. It getting generated 5-10 times during each screen. Ideally, we only need to generate the sequence when data is updated. |
This was referenced Jan 9, 2025
shobhitagarwal1612
force-pushed
the
ashobhit/2958/task-sequence-2
branch
from
af94eb3 to
a511ecb
Compare
…value is emitted.
This was referenced Jan 10, 2025
# Conflicts: # ground/src/main/java/com/google/android/ground/ui/datacollection/DataCollectionViewModel.kt # ground/src/main/java/com/google/android/ground/ui/datacollection/TaskSequenceHandler.kt # ground/src/test/java/com/google/android/ground/ui/datacollection/TaskSequenceHandlerTest.kt
# Conflicts: # ground/src/main/java/com/google/android/ground/ui/datacollection/TaskDataHandler.kt
# Conflicts: # app/src/main/java/com/google/android/ground/ui/datacollection/DataCollectionViewModel.kt # app/src/main/java/com/google/android/ground/ui/datacollection/tasks/AbstractTaskFragment.kt
# Conflicts: # app/src/main/java/com/google/android/ground/ui/datacollection/TaskSequenceHandler.kt # app/src/test/java/com/google/android/ground/ui/datacollection/TaskSequenceHandlerTest.kt
|
Closing in favour of #3008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2958
@... PTAL?