fix macro HAVE_O_CLOEXEC when O_CLOEXEC not found #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This was referenced Jun 20, 2022
|
macro HAVE_O_CLOEXEC is defined automatic by cmake in file port_config.h.in, cmake will define HAVE_O_CLOEXEC equals 0, so #if directive on HAVE_O_CLOEXEC in file env_posix.cc should be '#if HAVE_O_CLOEXEC' , not '#if defined(HAVE_O_CLOEXEC)', |
|
@emptyx0 Did you want to sign the CLA? |
I have already signed the CLA , 3Q dalao |
fanquake
added a commit
to bitcoin-core/leveldb-subtree
that referenced
this pull request
Jul 27, 2022
1eeb1cb fix macro HAVE_O_CLOEXEC when O_CLOEXEC not found (emptyx.wong) Pull request description: google#624 was [buggy](google#624 (comment)). One bug was fixed in google@27dc99f. google#1028 addresses another one. This PR cherry-picks from google#1028, and is an alternative to bitcoin/bitcoin#25463. ACKs for top commit: fanquake: ACK 1eeb1cb - I think the likelyhood of this being merged upstream is quite low, so that shouldn't be a blocker in us merging it here. jarolrod: ACK 1eeb1cb Tree-SHA512: 67a4e05372e71ba12abf84c633284afbaa54852b616fc86939231e72d5054d9f7973caad5a18944a84f0fdf924f404a35b50287d53a704c7d320f04068800ebf
|
Also see #1149. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port_config.h define HAVE_O_CLOEXEC is 0 when O_CLOEXEC not found in fcntl.h, so condition '#if defined(HAVE_O_CLOEXEC)' hit. It could be verified on centos5