feat: Update govulncheck integration and enable CGO there #1478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1443
This will solve the above issue, but let's not close it until the release is out.
The disabling CGO env flag can be removed as it seems like govulncheck will successfully analyse CGO projects, just not actually do analysis on the C parts.
The comment about:
It is only partially true, as if the C parts are required to compile the application, if CGO is disabled, it cannot compile successfully.
We'll need to cherrypick this change into
main
after this is merged.