Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update govulncheck integration and enable CGO there #1478

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

another-rex
Copy link
Collaborator

@another-rex another-rex commented Jan 7, 2025

#1443

This will solve the above issue, but let's not close it until the release is out.

The disabling CGO env flag can be removed as it seems like govulncheck will successfully analyse CGO projects, just not actually do analysis on the C parts.

The comment about:

This still leaves govulncheck enabled for non C related calls.

It is only partially true, as if the C parts are required to compile the application, if CGO is disabled, it cannot compile successfully.

We'll need to cherrypick this change into main after this is merged.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.05%. Comparing base (1e295ee) to head (745d817).

Additional details and impacted files
@@            Coverage Diff             @@
##               v1    #1478      +/-   ##
==========================================
- Coverage   69.05%   69.05%   -0.01%     
==========================================
  Files         186      186              
  Lines       18346    18344       -2     
==========================================
- Hits        12669    12667       -2     
  Misses       5012     5012              
  Partials      665      665              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@another-rex another-rex merged commit b37c83e into google:v1 Jan 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants