-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a [reusable] workflow for building wheels #42
base: master
Are you sure you want to change the base?
Conversation
@aktech Would appreciate your input, particularly on the part that triggers the reusable workflow. |
45f8dc0
to
b485d4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me other than some minor nitpicks.
Also, I am guessing the extra files like bazel-*
and wheel is committed accidentally.
ffcdc16
to
02748ba
Compare
Ugh, yes, these are added to a |
fbe3d86
to
4baf81c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I stumbled across this PR via the same issue as the one linked in the code comment here, and I thought it would be nice to suggest a few improvements that I was able to notice. I had a chat with @peytondmurray beforehand so that this doesn't become an unsolicited review :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from my side and I'm happy I was able to help somewhat!
@hassler-google Is there anything else we need to do here? If not, could you please approve the workflow, then merge? |
This PR adds a workflow for building wheels. The workflow is triggered when