Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for clustered Memorystore products. #94

Merged
merged 6 commits into from
Sep 13, 2024
Merged

feat: Add support for clustered Memorystore products. #94

merged 6 commits into from
Sep 13, 2024

Conversation

murphyjacob4
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@murphyjacob4
Add support for clustered Memorystore products.
c05bff1 
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
@murphyjacob4 murphyjacob4 requested review from a team as code owners September 12, 2024 20:54
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Sep 12, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: redis Issues related to the googleapis/langchain-google-memorystore-redis-python API. label Sep 12, 2024
PingXie
PingXie reviewed Sep 13, 2024
View reviewed changes
docs/chat_message_history.ipynb Outdated Show resolved Hide resolved
docs/chat_message_history.ipynb Outdated Show resolved Hide resolved
docs/document_loader.ipynb Outdated Show resolved Hide resolved
docs/document_loader.ipynb Outdated Show resolved Hide resolved
docs/vector_store.ipynb Outdated Show resolved Hide resolved
docs/vector_store.ipynb Outdated Show resolved Hide resolved
samples/langchain_quick_start.ipynb Outdated Show resolved Hide resolved
docs/vector_store.ipynb Outdated Show resolved Hide resolved
docs/chat_message_history.ipynb Outdated Show resolved Hide resolved
docs/chat_message_history.ipynb Outdated Show resolved Hide resolved
@PingXie
Copy link
Contributor

PingXie commented Sep 13, 2024

I see some formatting errors, BTW.

@murphyjacob4
Run black formatter.
3cc35ab 
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
@murphyjacob4
Fix documentation per PR review comments.
d442e74 
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
@murphyjacob4
Run isort to fix import order.
6cd137a 
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
@murphyjacob4
Remove duplicated get_env_var helper.
2b89b68 
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
@murphyjacob4
Remove trailing newline
d398b6c 
Signed-off-by: Jacob Murphy <jkmurphy@google.com>
@murphyjacob4
Copy link
Contributor Author

/gcbrun

2 similar comments
@PingXie
Copy link
Contributor

PingXie commented Sep 13, 2024

/gcbrun

@PingXie
Copy link
Contributor

PingXie commented Sep 13, 2024

/gcbrun

@PingXie PingXie merged commit 396ad18 into googleapis:main Sep 13, 2024
13 checks passed
@release-please release-please bot mentioned this pull request Aug 19, 2024
Merged
@averikitsch averikitsch mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PingXie PingXie PingXie approved these changes

Assignees

@PingXie PingXie

Labels
api: redis Issues related to the googleapis/langchain-google-memorystore-redis-python API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murphyjacob4 @PingXie