Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Correcting typo in variable declaration for internal class and implementation #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: Correcting typo in variable declaration for internal class and implementation #128

wants to merge 1 commit into from

Conversation

gauravpurohit06
Copy link
Contributor

@gauravpurohit06 gauravpurohit06 commented Jan 10, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #117

@gauravpurohit06
refactor: Correcting typo in variable declaration
eb1acf9 
Change is backward compatible as the class is for internal use.
@gauravpurohit06 gauravpurohit06 requested review from a team as code owners January 10, 2025 07:35
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/langchain-google-spanner-python API. label Jan 10, 2025
@gauravpurohit06 gauravpurohit06 linked an issue Jan 10, 2025 that may be closed by this pull request
langchain_google_spanner: typos in class names “ GoogleSqlSemnatics” and “ PGSqlSemnatics” #117
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rahul2393 rahul2393

Labels
api: spanner Issues related to the googleapis/langchain-google-spanner-python API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

langchain_google_spanner: typos in class names “ GoogleSqlSemnatics” and “ PGSqlSemnatics”
2 participants
@gauravpurohit06 @rahul2393