Skip to content

Commit

Permalink
making system tests work (#2)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexander-fenster authored Nov 16, 2017
1 parent 898b1ea commit 28fdfd2
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 6 deletions.
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ jobs:
name: Run system tests.
command: npm run system-test
environment:
GCLOUD_PROJECT: long-door-651
GOOGLE_APPLICATION_CREDENTIALS: .circleci/key.json
- run:
name: Remove unencrypted key.
Expand Down
4 changes: 4 additions & 0 deletions CONTRIBUTORS
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,16 @@
#
Ace Nassri <anassri@google.com>
Alexander Fenster <fenster@google.com>
Ashley Schuett <ashleyns1992@gmail.com>
Cristian Cavalli <cristiancavall@google.com>
Dave Gramlich <callmehiphop@gmail.com>
Eric Uldall <ericuldall@gmail.com>
Jason Dobry <jdobry@google.com>
Luke Sneeringer <lukesneeringer@google.com>
Michael Darakananda <pongad@google.com>
Ryan Hughes <ryanhugh@users.noreply.github.com>
Ryan Seys <ryan@ryanseys.com>
Stephen Sawchuk <sawchuk@gmail.com>
Tim Swast <swast@google.com>
Zach Bjornson <bjornson@stanford.edu>
c0b <14798161+c0b@users.noreply.github.com>
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,20 +71,21 @@ const projectId = 'YOUR_PROJECT_ID';

// Instantiates a client
const bigquery = BigQuery({
projectId: projectId
projectId: projectId,
});

// The name for the new dataset
const datasetName = 'my_new_dataset';

// Creates the new dataset
bigquery.createDataset(datasetName)
.then((results) => {
bigquery
.createDataset(datasetName)
.then(results => {
const dataset = results[0];

console.log(`Dataset ${dataset.id} created.`);
})
.catch((err) => {
.catch(err => {
console.error('ERROR:', err);
});
```
Expand Down
6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,23 @@
"contributors": [
"Ace Nassri <anassri@google.com>",
"Alexander Fenster <fenster@google.com>",
"Ashley Schuett <ashleyns1992@gmail.com>",
"Cristian Cavalli <cristiancavall@google.com>",
"Dave Gramlich <callmehiphop@gmail.com>",
"Eric Uldall <ericuldall@gmail.com>",
"Jason Dobry <jdobry@google.com>",
"Luke Sneeringer <lukesneeringer@google.com>",
"Michael Darakananda <pongad@google.com>",
"Ryan Hughes <ryanhugh@users.noreply.github.com>",
"Ryan Seys <ryan@ryanseys.com>",
"Stephen Sawchuk <sawchuk@gmail.com>",
"Tim Swast <swast@google.com>",
"Zach Bjornson <bjornson@stanford.edu>",
"c0b <14798161+c0b@users.noreply.github.com>"
],
"scripts": {
"generate-scaffolding": "repo-tools generate all && repo-tools generate lib_samples_readme -l samples/ --config ../.cloud-repo-tools.json",
"publish-module": "node ../../scripts/publish.js bigquery",
"test": "mocha test/*.js",
"system-test": "mocha system-test/*.js --no-timeouts --bail",
"benchmark": "time node benchmark/bench.js benchmark/queries.json",
"docs": "repo-tools exec -- jsdoc -c .jsdoc.js",
"lint": "repo-tools lint --cmd eslint -- src/ samples/ system-test/ test/",
Expand Down

0 comments on commit 28fdfd2

Please sign in to comment.