Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(getFiles): add nextPageToken to fields for autoPaginate #2570

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jjaareet
Copy link
Contributor

@jjaareet jjaareet commented Jan 14, 2025

bucket.getFiles() - returns all files as expected
bucket.getFiles({fields: 'items(name)'}) - unexpectedly returns only 1,000 files

i noticed that autoPaginate and fields do not play nicely together unless nextPageToken is added to fields. hoping to prevent someone else from banging their head on that wall with this change

edit: sorry for the force push after requesting review, just noticed a typo in the commit message

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Jan 14, 2025
@jjaareet jjaareet marked this pull request as ready for review January 14, 2025 16:43
@jjaareet jjaareet requested review from a team as code owners January 14, 2025 16:43
@jjaareet jjaareet changed the title fix(getFiles): add nextPageTokento fields for autoPaginate fix(getFiles): add nextPageToken to fields for autoPaginate Jan 14, 2025
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2025
@ddelgrosso1
Copy link
Contributor

@jjaareet thank you for the contribution!

@ddelgrosso1 ddelgrosso1 merged commit 75c309c into googleapis:main Jan 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants