-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: refine constraint to avoid numpy pandas incompatability #277
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have two questions:
- Why don't we pin pandas to be 2.2.2 instead?
- Owlbot made some change. Maybe we will need to revert that and add it to the owlbot.py
Ideally, we'd spread out the versions of pandas we test. For pinning one of the newer versions of pandas, that should be on one of the later Python versions. Note that currently, we test on:
Ideally, we would test on multiple 2.x versions but continue to have the latest supported Python test with latest supported pandas. Also, we might want to consider bumping our minimum pandas to 1.5.x sometime. That's the latest 1.x release and has the most flexibility of 1.x versions with regards to extension dtypes and pyarrow support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pins the version of
numpy
used withpython 3.9
to be less than2.0.0
.There is a potentially unexpected interaction between
pandas
andnumpy
here. Depending on the version we use for each, we get different results in terms of pass/fail for the unit tests associated withpython 3.9
This appears to be a known incompatibility between how
pip
resolves the dependency versions fornumpy
andpandas
and the only current fix is to pin versions to something that "works" to avoid allowingpip
to resolve into a failing state. (NOTE the linked issue references various versions of numpy and pandas, depending on the combination, inlcuding 3.9 throughout the thread, even though the title referencespython 3.12
)Fixes #275 🦕