Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication component that tracks user authentication status #45
Authentication component that tracks user authentication status #45
Changes from 19 commits
811bf03
2e849c2
97bf095
052f252
9590890
3061b84
a939496
bdb33bd
98dfecb
8c47834
6366786
3e6c329
3370ed1
2702dd0
d556223
e290972
8aecb0f
d0aa338
2930d3d
beecb6b
8664a60
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly,
...rest
are all the props passed into this component besidesRouteComponent
so justpath
. So then where doesrouteProps
come from? Also why is itrender
instead ofcomponent
? Should it have the same props as one like this:<Route path={ROUTES.SIGN_IN} component={SignInPage} />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially I just want PrivateRoute to act exactly as a Route component, with the added authentication check. So yeah you have the right idea that
...rest
are just all the other props passed intoPrivateRoute
. I then used a render prop to specify that the component to be rendered is either theRouteComponent
, if the user is logged in, or aRedirect
component if the user is not logged in. TherouteProps
are the props that are usually passed into theRouteComponent
, such as URL params, etc.If you think it would be beneficial to comment my code on some of these I can definitely do that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a brief comment mentioning this would be good. +1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, will do that before merging.