Skip to content

Commit

Permalink
feat(track): performance improvements (#988)
Browse files Browse the repository at this point in the history
- Adds playwright
- Add playwright test which measures how long it takes to zoom in an example spec (from
- Improve performance of json-type by removing deep-clones of spec/data #823 (comment))
- Persist resolved spec as a property of GoslingTrackClass so that it doesn't have to be regenerated every time
- Minimize number of deep clones of the spec or the data.
  • Loading branch information
etowahadams authored Dec 4, 2023
1 parent 3bd9607 commit edd24de
Show file tree
Hide file tree
Showing 15 changed files with 83,049 additions and 82 deletions.
27 changes: 27 additions & 0 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Playwright Tests
on:
push:
branches: [ main, master ]
pull_request:
branches: [ main, master ]
jobs:
test:
timeout-minutes: 60
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Install dependencies
run: yarn
- name: Install Playwright Browsers
run: yarn playwright install --with-deps chromium
- name: Run Playwright tests
run: yarn playwright test
- uses: actions/upload-artifact@v3
if: always()
with:
name: playwright-report
path: playwright-report/
retention-days: 30
15 changes: 15 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Playwright Tests 2
on:
issue_comment:
types: [created]
jobs:
test:
timeout-minutes: 60
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Install dependencies
run: yarn
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,6 @@ report.*
*.swp
*.swo
*~
/test-results/
/playwright-report/
/playwright/.cache/
Binary file added e2e/assets/example-spec-expected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit edd24de

Please sign in to comment.