Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: React-less and HiGlass-less Gosling.js #1094

Open
wants to merge 169 commits into
base: main
Choose a base branch
from
Open

feat: React-less and HiGlass-less Gosling.js #1094

wants to merge 169 commits into from

Conversation

sehilyi
Copy link
Member

@sehilyi sehilyi commented Jan 9, 2025

This is a PR of @etowahadams's fork that tries to get rid of HiGlass and React dependencies. Not yet ready to merge.

  • Etowah's comment of things left
  • More extensive testing of the new renderer. It seems to work well for the examples in the editor, but I'm sure we'll find more bugs. We have ways to comprehensively test certain aspects of the spec but not all.
  • React API: I implemented a basic GoslingComponent but it doesn't have all of the features of the current component. I don't think this will be too difficult though.

Issues to Address

  • Zoom speed has been changed when using mouse wheels (much faster when tested in this PR)
  • BAM file won't load (bam-data-fetcher.ts:55 Uncaught (in promise) ReferenceError: Buffer is not defined)
  • TrackTemplates does not work, resulting in the empty canvas (Track Templates: Genes, Sequence, and Ideograms example in the Editor)

Fix #
Toward #

Change List

Checklist

  • Ensure the PR works with all demos on the online editor
  • Unit tests added or updated
  • Examples added or updated
  • Documentation updated (e.g., added API functions)
  • Screenshots for visual changes (e.g., new encoding support or UI change on Editor)

@sehilyi sehilyi mentioned this pull request Jan 9, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants