-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for updating Go #1327
Draft
ptodev
wants to merge
1
commit into
main
Choose a base branch
from
ptodev/update-build-image-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add docs for updating Go #1327
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Updating Alloy to a new Go version | ||
|
||
There is more to updating Go than simply updating the `go.mod` file. | ||
You will need to submit two pull requests: | ||
|
||
1. [Create a new build image.][build-image-instructions] | ||
2. Update Alloy to use the new Go version, and the new build image. | ||
See [this][example-pr] pull request for an example. | ||
At this point you can just search and replace all instances of the old version with the new one. | ||
For example, "1.22.1" would be replaced with "1.22.5". | ||
|
||
The Go image which is used may sometimes have a name, like "bullseye". | ||
The origins of the name are explained in more detail in [Go's DockerHub repository][go-dockerhub]: | ||
|
||
> Some of these tags may have names like bookworm or bullseye in them. | ||
> These are the suite code names for releases of Debian and indicate which release the image is based on. | ||
> If your image needs to install any additional packages beyond what comes with the image, | ||
> you'll likely want to specify one of these explicitly to minimize breakage when there are new releases of Debian. | ||
|
||
[build-image-instructions]:../../tools/build-image/README.md | ||
[go-dockerhub]:https://hub.docker.com/_/golang | ||
[example-pr]:https://github.com/grafana/alloy/pull/1256/files |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattdurham Is it intentional that this container is unused? In Agent it's only used for building a Windows boringcrypto image, but in Alloy we don't seem to build such an image.