Add json format support for log export via faro receiver #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravishankar15
requested review from
clayton-cornell and
a team
as code owners
clayton-cornell
added
the
type/docs
|
Docs look as for now. Over to @grafana/grafana-alloy-maintainers for a code review. |
|
Hi @ravishankar15, would you mind rebasing your branch with Apologies for the delay with merging - I'll merge it after it's rebased to avoid further conflicts with the changelog :) |
ravishankar15
force-pushed
the
faro-log-format
branch
from
693fd76 to
45b21db
Compare
|
Hi @ptodev I have rebased the branch |
ptodev
reviewed
Dec 18, 2024
Fix chan size
ravishankar15
force-pushed
the
faro-log-format
branch
from
77997f0 to
61f5b97
Compare
|
@ptodev Anything else needed for this PR ? |
clayton-cornell
approved these changes
Jan 7, 2025
|
@ptodev would be really nice to get this feature in 🙏🏻 |
|
Apologies for the delay! I was on vacation for a few days :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Fixes #1973
Notes to the Reviewer
PR Checklist