Don't start components until Run is called #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildum
reviewed
Dec 18, 2024
|
Hi @wildum, I polished the PR a bit. Please feel free to merge it in if you are still happy with it. I'll lift my "needs improvement" on #2262 and will let @thampiotr review it again. I'm a co-author now, so it doesn't feel right to approve it :) |
wildum
added a commit
that referenced
this pull request
Jan 2, 2025
* make otel scheduler sync * Don't start components until Run is called (#2296) * Don't start components until Run is called * Update consumers after stopping the component * Minor fixes * Update internal/component/otelcol/internal/scheduler/scheduler.go Co-authored-by: Piotr <17101802+thampiotr@users.noreply.github.com> * test and docs * add resume call on exist for robustness --------- Co-authored-by: Paulin Todev <paulin.todev@gmail.com> Co-authored-by: Piotr <17101802+thampiotr@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch to #2262 which prevents the OTel components from being started during New. It was discussed in this thread.