Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.5] fix(pyroscope.receive_http): Handle metrics registry gracefully #2303

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[release/v1.5] fix(pyroscope.receive_http): Handle metrics registry gracefully #2303

merged 1 commit into from
Dec 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport 2b42ec4 from #2302

@simonswine @grafanabot
fix(pyroscope.receive_http): Handle metrics registry gracefully (#2302)
fb792cf 
This component did not handle duplciate registrations well.

This fixes #2285.

(cherry picked from commit 2b42ec4)
@github-actions github-actions bot requested a review from a team as a code owner December 19, 2024 15:42
@github-actions github-actions bot requested a review from simonswine December 19, 2024 15:42
simonswine
simonswine approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonswine simonswine merged commit 2594b77 into release/v1.5 Dec 19, 2024
5 checks passed
@simonswine simonswine deleted the backport-2302-to-release/v1.5 branch December 19, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simonswine