Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @grafana/beyla as CODEOWNERS for beyla component #2343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use @grafana/beyla as CODEOWNERS for beyla component #2343

wants to merge 1 commit into from

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jan 7, 2025

PR Description

Use @grafana/beyla instead of only @marctuduri to be the owner of the beyla.ebpf component.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@marctc marctc requested a review from a team as a code owner January 7, 2025 10:10
@marctc
Copy link
Contributor Author

marctc commented Jan 7, 2025

I think we need add Beyla team as collaborator of the repo, because I'm seeing this:

Unknown owner on line 25: make sure the team @grafana/beyla exists, is publicly visible, and has write access to the repository

@wildum
Copy link
Contributor

wildum commented Jan 7, 2025

not sure if I can do that, maybe @mattdurham knows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildum wildum wildum approved these changes

@ptodev ptodev ptodev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marctc @wildum @ptodev