Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable debug metrics for components inside foreach, and for foreach itself. #2404

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Disable debug metrics for components inside foreach, and for foreach itself. #2404

merged 1 commit into from
Jan 15, 2025

Conversation

ptodev
Copy link
Collaborator

@ptodev ptodev commented Jan 15, 2025

Opening a separate PR for @wildum to review the changes before they go on the main dynamic pipelines branch.

@ptodev ptodev requested a review from wildum January 15, 2025 10:39
@ptodev ptodev requested a review from a team as a code owner January 15, 2025 10:39
wildum
wildum reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good overall, I really like the added tests, just a few small comments

internal/runtime/foreach_metrics_test.go Outdated Show resolved Hide resolved
internal/runtime/foreach_test.go Outdated Show resolved Hide resolved
internal/runtime/foreach_test.go Outdated Show resolved Hide resolved
internal/runtime/internal/controller/node_builtin_component.go Show resolved Hide resolved
internal/runtime/internal/controller/node_config_foreach.go Outdated Show resolved Hide resolved
internal/runtime/testdata/foreach_metrics/foreach_2.txtar Outdated Show resolved Hide resolved
internal/runtime/testdata/foreach_metrics/foreach_1.txtar Outdated Show resolved Hide resolved
internal/runtime/testdata/foreach_metrics/foreach_2.txtar Show resolved Hide resolved
@ptodev ptodev force-pushed the ptodev/dynamic-pipelines-disable-metrics branch from 5578777 to 6a2db08 Compare January 15, 2025 14:55
@ptodev ptodev merged commit 30766dd into ptodev/dynamic-pipelines Jan 15, 2025
15 checks passed
@ptodev ptodev deleted the ptodev/dynamic-pipelines-disable-metrics branch January 15, 2025 15:26
ptodev added a commit that referenced this pull request Jan 27, 2025
@ptodev
Disable debug metrics for components inside foreach, and for foreach …
0b9f400 
…itself. (#2404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildum wildum wildum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptodev @wildum