Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and lint discovery.ec2 to discovery.ionos #2426

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

clayton-cornell
Copy link
Contributor

@clayton-cornell clayton-cornell commented Jan 16, 2025

PR Description

General cleanup, including things like:

  • Pretty print tables
  • Sort table rows alphabetically - required first, then all optional
  • Sort blocks alphabetically
  • Fix block heading hierarchy
  • Add badge for Required blocks
  • Remove block from heading text
  • Remove extra spaces and extra CR/LFs
  • Tidy markdown - spaces around lists, indentation, etc.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@clayton-cornell clayton-cornell changed the title Update EC2 topic Update and lint Discovery topics second group Jan 16, 2025
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

💻 Deploy preview deleted.

@clayton-cornell
Copy link
Contributor Author

Related issue #2411

@clayton-cornell clayton-cornell requested a review from a team January 20, 2025 20:58
@clayton-cornell clayton-cornell marked this pull request as ready for review January 20, 2025 20:58
@clayton-cornell clayton-cornell changed the title Update and lint Discovery topics second group Update and lint discovery.ec2 to discovery.ionos Jan 21, 2025
@clayton-cornell clayton-cornell force-pushed the docs/update_discovery_component_docs_part_4 branch from 341f364 to 7c39706 Compare January 21, 2025 17:47
@clayton-cornell clayton-cornell merged commit 338f893 into main Jan 23, 2025
24 checks passed
@clayton-cornell clayton-cornell deleted the docs/update_discovery_component_docs_part_4 branch January 23, 2025 17:38
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
* Update EC2 topic

* Updated eureka topic

* Update file topic

* Update GCE topic

* Update Hetzner topic

* Update HTTP and Ionos topics

* Updates for consistency and add missing descriptions

* Removed obsolete note

* Fix sentence structure

* Add quotes to Examples and fix a couple typos

* Add stage metadata

(cherry picked from commit 338f893)
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
* Update EC2 topic

* Updated eureka topic

* Update file topic

* Update GCE topic

* Update Hetzner topic

* Update HTTP and Ionos topics

* Updates for consistency and add missing descriptions

* Removed obsolete note

* Fix sentence structure

* Add quotes to Examples and fix a couple typos

* Add stage metadata

(cherry picked from commit 338f893)
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
* Update EC2 topic

* Updated eureka topic

* Update file topic

* Update GCE topic

* Update Hetzner topic

* Update HTTP and Ionos topics

* Updates for consistency and add missing descriptions

* Removed obsolete note

* Fix sentence structure

* Add quotes to Examples and fix a couple typos

* Add stage metadata

(cherry picked from commit 338f893)
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
* Update EC2 topic

* Updated eureka topic

* Update file topic

* Update GCE topic

* Update Hetzner topic

* Update HTTP and Ionos topics

* Updates for consistency and add missing descriptions

* Removed obsolete note

* Fix sentence structure

* Add quotes to Examples and fix a couple typos

* Add stage metadata

(cherry picked from commit 338f893)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants