Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pyroscope.receive_http): Support pushv1.Push in receive_http #2431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Jan 16, 2025

The Pyroscope backend has currently two ingest API:

  • /ingest, which is predominatnely used by the Pyroscope SDKs
  • /push.v1.PusherService/Push which is a connect API used by profilecli and pyroscope.write with pyroscope.ebpf and pyroscope.alloy

This adds the missing support for /push.v1.PusherService/Push

Fixes #2301

@simonswine simonswine force-pushed the 20250116_support-pusher-v1-receive.http branch from 0c923f5 to 7e2e94e Compare January 17, 2025 12:19
@simonswine simonswine changed the title Support pushv1 in receive_http feat(pyroscope.receive_http): Support pushv1.Push in receive_http Jan 17, 2025
@simonswine simonswine force-pushed the 20250116_support-pusher-v1-receive.http branch from 7e2e94e to 3ed0357 Compare January 17, 2025 12:44
@simonswine simonswine marked this pull request as ready for review January 17, 2025 13:48
@simonswine simonswine requested a review from a team as a code owner January 17, 2025 13:48
@simonswine simonswine requested a review from marcsanmi January 17, 2025 15:40
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I think we should update the pyroscope.receive_http.md docs, which were originally written to explicitly cover HTTP ingestion API support.

I also believe CHANGELOG.md needs to be updated.

@simonswine simonswine requested review from clayton-cornell and a team as code owners January 29, 2025 08:24
/push.v1.PusherService/Push which is a connect API used by profilecli
and pyroscope.write with pyroscope.ebpf and pyroscope.alloy.

This is in addtion to the /ingest API the component already supports.
@simonswine simonswine force-pushed the 20250116_support-pusher-v1-receive.http branch from f53bd49 to 088f707 Compare January 29, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyroscope.receive_http should support the connect go handlers
2 participants