Update and lint discovery.kubelet to discovery.nomad #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
the
type/docs
|
Related issue #2411 |
|
💻 Deploy preview deleted. |
clayton-cornell
changed the title
clayton-cornell
force-pushed
the
docs/update_discovery_component_docs_part_5
branch
from
faf40ac to
0fd7084
Compare
ptodev
approved these changes
Jan 23, 2025
| they are not bound to an endpoint port. | ||
| The `endpoints` role discovers targets from listed endpoints of a service. | ||
| For each endpoint address one target is discovered per port. | ||
| If the endpoint is backed by a Pod, all container ports of a Pod are discovered as targets even if they aren't bound to an endpoint port. |
There was a problem hiding this comment.
Why is it Pod instead of pod?
There was a problem hiding this comment.
Kubernetes refers to Pods with a capital P. So, we follow that guideline: https://kubernetes.io/docs/concepts/workloads/pods/
And I try to catch all the instances of K8s pod to swap to Pod
docs/sources/reference/components/discovery/discovery.linode.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
clayton-cornell
deleted the
docs/update_discovery_component_docs_part_5
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Update Kubernetes topic * Update Kuma topic * Update Lightsail topic * Update linode topic * Update marathon topic * Update nerve topic * Update nomad topic * Update missing descriptions and fix layout * Fix a couple sentences * Add quotes in examples and stage metadata * Update docs/sources/reference/components/discovery/discovery.linode.md Co-authored-by: Paulin Todev <paulin.todev@gmail.com> --------- Co-authored-by: Paulin Todev <paulin.todev@gmail.com> (cherry picked from commit c34284f)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Update Kubernetes topic * Update Kuma topic * Update Lightsail topic * Update linode topic * Update marathon topic * Update nerve topic * Update nomad topic * Update missing descriptions and fix layout * Fix a couple sentences * Add quotes in examples and stage metadata * Update docs/sources/reference/components/discovery/discovery.linode.md Co-authored-by: Paulin Todev <paulin.todev@gmail.com> --------- Co-authored-by: Paulin Todev <paulin.todev@gmail.com> (cherry picked from commit c34284f)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Update Kubernetes topic * Update Kuma topic * Update Lightsail topic * Update linode topic * Update marathon topic * Update nerve topic * Update nomad topic * Update missing descriptions and fix layout * Fix a couple sentences * Add quotes in examples and stage metadata * Update docs/sources/reference/components/discovery/discovery.linode.md Co-authored-by: Paulin Todev <paulin.todev@gmail.com> --------- Co-authored-by: Paulin Todev <paulin.todev@gmail.com> (cherry picked from commit c34284f)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Update Kubernetes topic * Update Kuma topic * Update Lightsail topic * Update linode topic * Update marathon topic * Update nerve topic * Update nomad topic * Update missing descriptions and fix layout * Fix a couple sentences * Add quotes in examples and stage metadata * Update docs/sources/reference/components/discovery/discovery.linode.md Co-authored-by: Paulin Todev <paulin.todev@gmail.com> --------- Co-authored-by: Paulin Todev <paulin.todev@gmail.com> (cherry picked from commit c34284f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
General cleanup, including things like:
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist