database_observability: Fix handling of view table types when detecting schema. #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL returns different column count for SHOW CREATE VIEW when compared to SHOW CREATE TABLE. This change adds conditional logic to handle both cases so that we can extract the schema of a view without generating an error.
internal/component/database_observability/mysql/collector/schema_table.go
Outdated
Show resolved
Hide resolved
matthewnolf
force-pushed
the
mn/dbo11y-parse-view-schema
branch
from
6a8aa6c to
dd4e2f8
Compare
internal/component/database_observability/mysql/collector/schema_table.go
Show resolved
Hide resolved
cristiangreco
approved these changes
Jan 20, 2025
clayton-cornell
pushed a commit
that referenced
this pull request
Jan 21, 2025
…ng schema. (#2443) MySQL returns different column count for SHOW CREATE VIEW (2 columns) when compared to SHOW CREATE TABLE (4 columns). This change adds conditional logic to handle both cases so that we can extract the schema of a view without generating an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
MySQL returns different column count for
SHOW CREATE VIEW(2 columns) when compared toSHOW CREATE TABLE(4 columns).This change adds conditional logic to handle both cases so that we can extract the schema of a view without generating an error.
There are a couple small refactors:
schema_table_test.gofor the different scenariosWhich issue(s) this PR fixes
Notes to the Reviewer
PR Checklist