Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Beyla to version 1.5.1 #645

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Bump Beyla to version 1.5.1 #645

merged 3 commits into from
Apr 23, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Apr 23, 2024

PR Description

Bumps Beyla to version 1.5.1, which includes a bunch of bugfixes.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@marctc marctc requested a review from a team April 23, 2024 10:11
CHANGELOG.md Outdated
@@ -39,6 +39,7 @@ Main (unreleased)
- Update `alloy-mixin` to use more specific alert group names (for example,
`alloy_clustering` instead of `clustering`) to avoid collision with installs
of `agent-flow-mixin`. (@rfratto)
- Bump Beyla to v1.5.1. (@marctc)
Copy link
Contributor

@ptodev ptodev Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, it'd be good to mention how this affects Alloy users. Would that be very difficult to do? It seems there are lots of changes in 1.5.0, so maybe it's not very easy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't affect users in a notable way, then maybe we don't need to mention this upgrade in the changelog.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not quite sure which version we're upgrading from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would linking to Beyla's changelog be enough? There aren't changes to Beyla component itself, just internal changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, for exporters when bumping to a newer version we rarely explained what changed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does every change in Beyla's changelog impact Alloy users? It would be most helpful if you just describe in one sentence what the sorts of improvements are noteworthy from an Alloy user point of view. I'm still not sure which version we're upgrading from, so not sure which changelog to link to also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does every change in Beyla's changelog impact Alloy users?

No, only the users that use Beyla's componet in Alloy.

@rfratto rfratto added the backport-to-agent:no PR should NOT be backported to the agent repo. label Apr 23, 2024
@marctc marctc merged commit c91d76e into main Apr 23, 2024
13 checks passed
@marctc marctc deleted the bump_beyla_1.5.1 branch April 23, 2024 13:12
hainenber pushed a commit to hainenber/alloy that referenced this pull request May 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-to-agent:no PR should NOT be backported to the agent repo. frozen-due-to-age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants