-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove 'd' from duration values spec #674
Conversation
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
cc @rfratto for visibility, I'll go ahead and merge this if there's no objections. |
To be precise, Alloy/Flow mode has never supported it, but Prometheus and static mode of Grafana Agent do thanks to Personally I find most people mean 1d to be 24h, even if sometimes a day is not exactly 24h. I'm ok with us fixing the docs since no component uses |
Thanks for the feedback! I've verified that the converters do handle days properly (1d gets converted to 24h0m0s). I'm merging this. |
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com> (cherry picked from commit eab8cd9)
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
Fixes #599
This PR addresses a spec inconsistency. This is not a breaking change, since
d
was never actually supported as a valid duration unit.I still think that the Go team had a good rationale for not adding support for it in time.ParseDuration; if it's so important for people to use higher values we could find a way to support richer expressions such as
5 * 24h
in the future instead.