loader: decrease log level of 'finished node evaluation' lines #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
rfratto
approved these changes
Apr 26, 2024
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
…na#682) Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR decreases the log level of the
msg="finished node evaluation"log lines, since they can drown out all other logsWhich issue(s) this PR fixes
No issue filed.
Notes to the Reviewer
I purposefully left the Info log level on the Apply function that is called on manual reloads of the configuration. I'm not 100% sure yet, but I think they might be marginally more useful to see new components being added in, but still they can be much more noisy than all other log sources.
I also think this doesn't warrant a CHANGELOG entry, if you think it does don't hesitate to push an extra commit for me here.
PR Checklist