Fix handling of slog logs before logging initialized #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogger is initialized.
mattdurham
changed the title
rfratto
reviewed
Apr 30, 2024
rfratto
reviewed
May 1, 2024
|
Made the changes, also good for pushing to use the default slogtest. I have to add a little hack but it works and is much cleaner. |
polyrain
pushed a commit
to polyrain/alloy
that referenced
this pull request
May 2, 2024
* add handlers * Add support for handling slog style logging that happens BEFORE the logger is initialized. * Update changelog * unexport deferred handler * clean up and add tests * refactor tests * fix refactor misname * fix test * cleanup changes * Use slog tests. * Remove DeferredHandler from Logger and always use a wrapped deferred handler. * pr feedback * Add more support for logging
rfratto
added
the
backport-to-agent:no
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Previously if you tried to use the logger for a slog style logger the system would panic. This adds a deferred handler for handling slog entries. The log buffer now supports normal logs and slog.Records and replays them in the appropriate order.
This is a lot of code to handle replaying of logs, its possible I could merge the deferred handler and the handler but then I think the logic would get real complicated.
PR Checklist