Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging: don't assume /var/lib/alloy exists when running chown #724

Merged
merged 2 commits into from
Apr 30, 2024
Merged

packaging: don't assume /var/lib/alloy exists when running chown #724

merged 2 commits into from
Apr 30, 2024
+14 −4

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Apr 30, 2024

The /var/lib/alloy directory may not necessarily exist when installing or upgrading Alloy, which would cause the chown/chmod of the directory to fail.

Related to grafana/alloy#723, though I haven't been able to reproduce the specific error that user was seeing.

rfratto added 2 commits April 30, 2024 13:50
@rfratto
packaging: don't assume /var/lib/alloy exists when running chown
ec98932 
The /var/lib/alloy directory may not necessarily exist when installing
or upgrading Alloy, which would cause the chown/chmod of the directory
to fail.

Related to grafana/alloy#723, though I haven't been able to reproduce
the specific error that user was seeing.
@rfratto
update CHANGELOG.md
03f4e41
@rfratto
Copy link
Member Author

rfratto commented Apr 30, 2024 •
edited
Loading

Locally ran make test-packages to make sure everything still works. I'm not entirely convinced this is necessary, and I still don't understand what the deal with #723 is, but at the very least it's probably good to have this change just to be defensive.

@rfratto rfratto added the backport-to-agent PR should be backported to the agent repo. label Apr 30, 2024
@rfratto rfratto merged commit 3dd7143 into main Apr 30, 2024
14 checks passed
@rfratto rfratto deleted the fix-linux-install-error branch April 30, 2024 18:42
hainenber pushed a commit to hainenber/alloy that referenced this pull request May 1, 2024
@rfratto @hainenber
packaging: don't assume /var/lib/alloy exists when running chown (gra…
17a985b 
…fana#724)

The /var/lib/alloy directory may not necessarily exist when installing
or upgrading Alloy, which would cause the chown/chmod of the directory
to fail.

Related to grafana/alloy#723, though I haven't been able to reproduce
the specific error that user was seeing.
polyrain pushed a commit to polyrain/alloy that referenced this pull request May 1, 2024
@rfratto @polyrain
packaging: don't assume /var/lib/alloy exists when running chown (gra…
d277e08 
…fana#724)

The /var/lib/alloy directory may not necessarily exist when installing
or upgrading Alloy, which would cause the chown/chmod of the directory
to fail.

Related to grafana/alloy#723, though I haven't been able to reproduce
the specific error that user was seeing.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikbaranowski erikbaranowski erikbaranowski approved these changes

Assignees
No one assigned
Labels
backport-to-agent PR should be backported to the agent repo. frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfratto @erikbaranowski