Reintroduce boringcrypto images #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
force-pushed
the
boringcrypto-images
branch
2 times, most recently
from
014d732 to
a832559
Compare
clayton-cornell
added
the
type/docs
rfratto
force-pushed
the
boringcrypto-images
branch
from
d4bd5eb to
1767da9
Compare
mattdurham
reviewed
Apr 30, 2024
mattdurham
approved these changes
Apr 30, 2024
This reverts commit c9daa54.
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
rfratto
force-pushed
the
boringcrypto-images
branch
from
5049940 to
09910ec
Compare
polyrain
pushed a commit
to polyrain/alloy
that referenced
this pull request
May 2, 2024
* misc: build boringcrypto and cngcrypto images for Linux and Windows * docs: document boringcrypto images * Revert "docs: temporarily remove boringcrypto references (grafana#97)" This reverts commit c9daa54. * Apply suggestions from code review Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * docs: use BoringCrypto/CNGCrypto as proper spelling --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
rfratto
added a commit
to rfratto/alloy
that referenced
this pull request
May 3, 2024
PR grafana#725 reintroduced boringcrypto support and mistakenly switched the quote syntax in the Dockerfile used to pass variables. This change was not necessary as the surrounding string already used double quotes, and making the change prevented the proper command from being passed to make.
rfratto
added a commit
that referenced
this pull request
May 3, 2024
PR #725 reintroduced boringcrypto support and mistakenly switched the quote syntax in the Dockerfile used to pass variables. This change was not necessary as the surrounding string already used double quotes, and making the change prevented the proper command from being passed to make.
github-actions bot
pushed a commit
that referenced
this pull request
May 3, 2024
PR #725 reintroduced boringcrypto support and mistakenly switched the quote syntax in the Dockerfile used to pass variables. This change was not necessary as the surrounding string already used double quotes, and making the change prevented the proper command from being passed to make. (cherry picked from commit ea8af41)
rfratto
added
the
backport-to-agent:no
rfratto
added a commit
that referenced
this pull request
May 3, 2024
… (#758) PR #725 reintroduced boringcrypto support and mistakenly switched the quote syntax in the Dockerfile used to pass variables. This change was not necessary as the surrounding string already used double quotes, and making the change prevented the proper command from being passed to make. (cherry picked from commit ea8af41) Co-authored-by: Robert Fratto <robertfratto@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces boringcrypto/cngcrypto Docker images to mirror boringcrypto/cngcrypto support in Grafana Agent.
Related to #64.
I'll follow up with another PR for distributing boringcrypto binaries after this is merged.