Add support for deletes in the memberlist backed KV store #612
+399
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
NickAnge
reviewed
Jan 16, 2025
NickAnge
reviewed
Jan 27, 2025
|
|
||
| val, err = kv1.Get(context.Background(), key) | ||
| require.NoError(t, err) | ||
| require.NotNil(t, val) |
There was a problem hiding this comment.
These values should be nil, no ? 🤔 We check the entry of the kvStore after we have waited 5 second, after the delete.
I observed two things:
- If there are in flight gossip messages with deleted false after we have deleted the entry from kv1, it can happen that the CAS operation will succeed and re-introduce the memberlist entry. Making this require Not nil successful. In a real world example this eventually will be deleted (I think), because the delete operation will be called every
[deletedTimeout](https://github.com/grafana/mimir/blob/9d27b48dadb4bf8587e35fb6aa8bdd9d8bc1171b/pkg/distributor/ha_tracker.go#L408). - If we wait for 10 seconds before deleting to avoid incoming inflight requests, the entry is deleted from kv1 but is not gossiped to kv2. This potentially would solve the first problem, but i cannot make it gossip the message with the delete 🤔 Do you know why ?
Let me know what you think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for deletes in the memberlist kv store.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]