-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM: Version packages using Lerna or Nx #294
base: main
Are you sure you want to change the base?
Conversation
@kminehart @aangelisc could I get some assistance with the fileexists utility and the |
… doesn't require the dag to be evaluated
After getting permission from @jackw I updated his branch here to change the approach. The biggest thing I changed was avoiding places where we have to execute the DAG in order to continue, which is basically any function that requires a While it's a bit ugly to do these types of conditionals in bash, it has a number of advantages, almost all around caching. Now, if nothing has changed on the frontend, the results will stay the same. Plus, the dagger server won't complain about us trying to get a file that doesn't exist 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it's still readable and straightforward to understand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping me out here @kminehart. I've left a comment related to the bash logic as I'm not sure these changes are gonna work with the associated Grafana branch.
Requirements
This is WIP right now whilst I get the grafana/grafana branch together and do all the tests.
The
main
branch ofgrafana-build
should be compatible with all active versions of Grafana and Grafana-Enterprise.main
in Grafana.main
in Grafana Enterprise.Why?
See this issue. TLDR; once these PRs are all merged we have the ability to create versioning strategies for different packages fixing the age old problem of "how do I add an NPM package to Grafana that doesn't get versioned and released with Grafana releases".
Associated PRs: