Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic when no overrides #287

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

malcolmholmes
Copy link
Collaborator

Overrides from environment variables go into a separate overrides node in the config, as
they cannot possibly know what the current context is and override the specific settings
on that variable path. However, if no overrides provided, kaboom. This PR unkabooms.

@malcolmholmes malcolmholmes requested a review from a team as a code owner December 17, 2023 08:13
@malcolmholmes malcolmholmes merged commit adf068c into master Dec 18, 2023
3 checks passed
@malcolmholmes malcolmholmes deleted the malcolmholmes/dont-panic-on-no-overrides branch December 18, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants