Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed docs theme and update it for recent hugo versions #554

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

K-Phoen
Copy link
Member

@K-Phoen K-Phoen commented Jan 10, 2025

Since hugo got updated in our github actions, docs can't be built.

They can't be built because the theme Grizzly is using relies on deprecated variables. That theme being unmaintained, I had to vendor it into this repo to address the build issues :|

@K-Phoen K-Phoen self-assigned this Jan 10, 2025
@K-Phoen K-Phoen requested a review from a team as a code owner January 10, 2025 11:27
@K-Phoen K-Phoen added the documentation Improvements or additions to documentation label Jan 10, 2025
Copy link

@Pokom Pokom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@K-Phoen any thoughts on forking the theme ourselves? I don't know how much we want to get into the business of maintaining themes, but we could use this theme for other projects potentially.

@K-Phoen
Copy link
Member Author

K-Phoen commented Jan 10, 2025

I think I'd prefer standardizing our docs to the mkdocs + Material theme (which we use for the Foundation SDK and grafonnet).

They're both maintained, so no need for us to fork anything 😅

@K-Phoen K-Phoen merged commit a2f73a8 into main Jan 10, 2025
8 checks passed
@K-Phoen K-Phoen deleted the fix-docs branch January 10, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants