-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce packaging to Docker Mixin #998
base: master
Are you sure you want to change the base?
Conversation
to test, render this:
|
spec: grafana.template.new( | ||
'instance', | ||
'$prometheus_datasource', | ||
'label_values(machine_scrape_error{job=~"$job"}, instance)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes variables depend on config (instead of hardcoded job=~"$job" it could be dynamic label selector). Does this packaging provide a way to provide custom labelsSelector from config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is entirely up to us to define, so I'm sure it can!
@@ -0,0 +1,45 @@ | |||
local host_matcher = 'job=~"$job", instance=~"$instance"'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite common that query selectors depend on config (instead of hardcoded job=~"$job" it could be user provided label selector). Does this packaging provide a way to provide custom host_matcher from config?
I think queries are better packed as targets (query + legend) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to see a more abstract description of the format, it's hard to untangle the format from the data in this PR.
A proposal for a packaging format for observability packages that is back-compatible with
Jsonnet Mixins.