-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add waitForEvent tasks to release notes #3413
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-notes-v0.48.0 #3413 +/- ##
========================================================
Coverage ? 73.11%
========================================================
Files ? 258
Lines ? 19650
Branches ? 0
========================================================
Hits ? 14367
Misses ? 4401
Partials ? 882
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
release notes/v0.48.0.md
Outdated
@@ -33,8 +33,7 @@ _Format as `<number> <present_verb> <object>. <credit>`_: | |||
|
|||
## Bug fixes | |||
|
|||
_Format as `<number> <present_verb> <object>. <credit>`_: | |||
- _`#111` fixes race condition in runtime_ | |||
- [browser#1042](https://github.com/grafana/xk6-browser/pull/1042), [browser#1069](https://github.com/grafana/xk6-browser/pull/1069) Fixes `browserContext.waitForEvent`. This fix involved promisifying the `waitForEvent` API as well as various internal refactors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that grafana/xk6-browser#1069 is not specifically related with waitForEvent
, as it also refactors the usage of TaskQueue
for Page.on
. Should we remove it from here and instead add an entry for it under Maintenance and internal improvements
section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point, it does include quite a bit of refactoring to move the taskqueue out of the common package and into the mapping layer. The main motivation (initially) for this PR though was due to the issue of not working with the taskqueue
when using the predicate function for waitForEvent
, i.e. without this change waitForEvent
wouldn't work. Happy to move it to Maintenance and internal improvements
though if you still think it should, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it feels moving the TaskQueue
to the mapping layer is a separate task. But no strong opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, happy with that change added it to a fixup: ef92133
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How specific should we be with these internal refactors? To be honest I'm never sure of what should be the level of detail in these cases. Considering that this is a completely internal change, I don't disagree with the current text, but I wonder if it should be more specific such as "Internal refactor to move Goja's TaskQueue away from core implementation" (or similar).
Since you are a reviewer for this also, any thoughts @oleiade ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind if i merge this and we can open a new issue for this if we need?
ef92133
to
b043560
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
b043560
to
09ebc51
Compare
What?
Update the next release notes with links to the PRs that have fixed and refactored code to get
waitForEvent
to work.Why?
To update the release notes for the next release.
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)