Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golangci-lint to latest v1.62.2 #4095

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update golangci-lint to latest v1.62.2 #4095

merged 1 commit into from
Dec 12, 2024

Conversation

mstoykov
Copy link
Contributor

What?

update golangci-lint to latest version

Quite a lot of gosec ones about integers under/overflows - I tried to fix the ones that weren't problematic, but there were quite a lot.

Why?

Keeping up to date makes it easier to update and it is harder for IC to keep the exact version we use locally and unfortuantely there are always differences.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov
Update golangci-lint to latest v1.62.2
f571cc8 
Quite a lot of gosec ones about integers under/overflows - I tried to
fix the ones that weren't problematic, but there were quite a lot.
@mstoykov mstoykov added this to the v0.56.0 milestone Dec 10, 2024
@mstoykov mstoykov requested a review from a team as a code owner December 10, 2024 14:56
@mstoykov mstoykov requested review from oleiade and joanlopez and removed request for a team December 10, 2024 14:56
@mstoykov mstoykov mentioned this pull request Dec 10, 2024
Open
olegbespalov
olegbespalov approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping in mind number of the type conversions, int/uint/etc with omitting of the gosec it sounds that it might be so that we probably need some refactoring, on the other side it's for sure out of scope of this PR, so LGTM 👍

lib/executor/ramping_arrival_rate_test.go Show resolved Hide resolved
ankur22
ankur22 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mstoykov mstoykov merged commit 1d1afd0 into master Dec 12, 2024
22 of 23 checks passed
@mstoykov mstoykov deleted the golangciLintUpdate branch December 12, 2024 10:26
@mstoykov mstoykov mentioned this pull request Dec 19, 2024
Merged
5 tasks
@BrewTestBot BrewTestBot mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegbespalov olegbespalov olegbespalov approved these changes

@ankur22 ankur22 ankur22 approved these changes

@oleiade oleiade oleiade approved these changes

@joanlopez joanlopez Awaiting requested review from joanlopez joanlopez is a code owner automatically assigned from grafana/k6-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.56.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mstoykov @oleiade @ankur22 @olegbespalov