Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internalize #4133

Draft
wants to merge 14 commits into
base: websocketsMerge
Choose a base branch
from
Draft

Internalize #4133

wants to merge 14 commits into from

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Dec 19, 2024 •
edited
Loading

What?

Move a lot of k6 code under internal

Why?

Define k6 public API

TODO:

  1. list commands to generate this
  2. polish
  3. check this doesn't break somethign
  4. repeat from 1

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov changed the base branch from master to websocketsMerge December 19, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mstoykov