Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an NPD when handle is overwritten with nil #4280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Jan 24, 2025

What?

Call the defer function with the non nil handle, and allow the handle to be overwritten later. Now the handle in the defer will still be non-nil.

Why?

Fixes an NPD.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Linked to: #4279

Call the defer function with the non nil handle, and allow the handle
to be overwritten later. Now the handle in the defer will still be
non-nil.
@ankur22 ankur22 requested a review from a team as a code owner January 24, 2025 16:27
@ankur22 ankur22 requested review from mstoykov, oleiade and inancgumus and removed request for a team January 24, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant