Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): adds a flag for tokengen rbac components so that they can be disabled optionally #15882

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

drew0ps
Copy link

@drew0ps drew0ps commented Jan 22, 2025

What this PR does / why we need it:

This PR adds the option to disable the RBAC manifests from the tokengen component. This is needed for enterprise kubernetes offerings where developers/service owners are not allowed to deploy rbac related manifests, only specific workload related ones. In such cases, deploying the RBAC manifests are typically done separately after approval or by an infrastructure team.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@drew0ps drew0ps requested a review from a team as a code owner January 22, 2025 15:43
@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Jan 22, 2025
@drew0ps drew0ps force-pushed the add-tokengen-rbac-flags branch from 3d6616e to a64a9f8 Compare January 22, 2025 15:44
@drew0ps drew0ps force-pushed the add-tokengen-rbac-flags branch from a64a9f8 to 463c58a Compare January 22, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants