[16.0][FIX] pos_order_to_sale_order

pos_order_to_sale_order/models/sale_order.py

@@ -14,8 +14,8 @@ def _prepare_from_pos(self, order_data):
         session = PosSession.browse(order_data["pos_session_id"])
         SaleOrderLine = self.env["sale.order.line"]
         order_lines = [
-            Command.create(SaleOrderLine._prepare_from_pos(i + 1, line_data[2]))
-            for (i, line_data) in enumerate(order_data["lines"])
+            Command.create(SaleOrderLine._prepare_from_pos(sequence, line_data[2]))
+            for sequence, line_data in enumerate(order_data["lines"], start=1)
         ]
         return {
             "partner_id": order_data["partner_id"],

pos_order_to_sale_order/models/sale_order_line.py

@@ -22,10 +22,9 @@ def _prepare_from_pos(self, sequence, order_line_data):
     def _get_sale_order_line_multiline_description_sale(self):
         res = super()._get_sale_order_line_multiline_description_sale()
 
-        for (i, line_data) in enumerate(
-            self.env.context.get("pos_order_lines_data", [])
+        for i, line_data in enumerate(
+            self.env.context.get("pos_order_lines_data", []), start=1
         ):
-            if line_data.get("customer_note", False) and self.sequence == i + 1:
-                res += "\n" + line_data.get("customer_note")
-
+            if line_data.get("customer_note", False) and self.sequence == i:
+                res += f"\n{line_data.get('customer_note')}"
         return res

pos_order_to_sale_order/tests/test_module.py

@@ -37,7 +37,25 @@ def test_pos_order_to_sale_order(self):
 
         order = after_orders[-1]
 
-        self.assertEqual(order.amount_total, 3.2)
-        self.assertEqual(order.state, "sale")
-        self.assertEqual(order.delivery_status, "full")
-        self.assertEqual(order.invoice_status, "invoiced")
+        self.assertEqual(
+            order.amount_total, 5.18, msg="Total Amount must be equal to 5.18"
+        )
+        self.assertEqual(order.state, "sale", msg="Order state must be equal to 'sale'")
+        self.assertEqual(
+            order.delivery_status, "full", msg="Delivery status must be equal to 'full'"
+        )
+        self.assertEqual(
+            order.invoice_status,
+            "invoiced",
+            msg="Invoice status must be equal to 'invoiced'",
+        )
+        self.assertNotIn(
+            "Product Note",
+            order.order_line[0].name,
+            msg="'Product Note' must contains in sale order line description",
+        )
+        self.assertIn(
+            "Product Note",
+            order.order_line[1].name,
+            msg="'Product Note' must not contains in sale order line description",
+        )

pos_order_to_sale_order/tests/tours/PosOrderToSaleOrderTour.tour.js

@@ -31,6 +31,25 @@ odoo.define("pos_order_to_sale_order.tour.PosOrderToSaleOrderTour", function (re
                 "Test pos_order_to_sale_order: Order a 'Whiteboard Pen' (price 3.20)",
             trigger: ".product-list .product-name:contains('Whiteboard Pen')",
         },
+        {
+            content:
+                "Test pos_order_to_sale_order: Order a 'Wall Shelf Unit' (price 1.98)",
+            trigger: ".product-list .product-name:contains('Wall Shelf Unit')",
+        },
+        {
+            context: "Test pos_order_to_sale_order: Customer Note for 'Whiteboard'",
+            trigger: '.control-buttons .control-button span:contains("Customer Note")',
+        },
+        {
+            context:
+                "Test pos_order_to_sale_order: Set Customer Note for product 'Whiteboard'",
+            trigger: ".popups .popup-textarea .popup-textarea-wrap textarea",
+            run: "text Product Note",
+        },
+        {
+            context: "Test pos_order_to_sale_order: Confirm Customer Note",
+            trigger: ".modal-dialog .confirm",
+        },
         {
             content: "Test pos_order_to_sale_order: Click on 'Customer' Button",
             trigger: "button.set-partner",