Refactor logic expressions #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still have to build Z3 for linux-aarch64, because the official release requires glibc 2.35 (and the corresponding libstdc++), while Amazon Linux 2023 only supports glibc 2.34. Also enabled optimization flags from Amazon Linux 2023 for the aarch64 Z3 build. This tecnically excludes older armv8-a platforms (like Raspberry Pi 4), but most modern SBC (like Raspberry Pi 5) already support armv8.2-a+crypto. At any rate, the need to run Refinery on such paltforms in unlikely. At any rate, the build flags should be supported on Neoverse N1-based cloud providers (including Amazon and Hetzner), as well as Apple M devices (armv8.5-a).
Also changes ReferenceDeclaration to declare attributes, since reference and attributes can only be distinguished at linking time.
Also reorganizes operator names for easier future extension.
* Customizable operator overloads. * Customizable aggregation operators. * Simplify ProblemQualifiedNameProvider.
Only highlight the * character as a number when it is not used as a multiplication operator.
Require all abstract domain elements to implement the AbstractValue interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in some commits form the ongoing attribute constraints work so that it doesn't diverge from the main branch too much.
Breaking change: move
Query,Dnf, andTermrelated classes fromrefinery-store-queryintorefinery-logic.Also adds Z3 bindings (with a custom build for Amazon Linux ARM).