fix rank issue, add metadata support and debug mode, add wrf, openfoam, lammps jarvis packages, clean the code and add cmake flags #45
Conversation
hxu65
changed the title
hxu65
changed the title
There was a problem hiding this comment.
@hxu65 you need to look into some of the comments, you need to either delete them or put them around a #ifdef debug if you want to
include/common/SQlite.h
Outdated
| char* errMsg = 0; | ||
| int rc = sqlite3_exec(db, sql.c_str(), callbackFunc, data, &errMsg); | ||
| if (rc != SQLITE_OK) { | ||
| std::cerr << "SQL error: " << errMsg << std::endl; | ||
| //std::cerr << "MDM: SQL error: " << errMsg << std::endl; |
There was a problem hiding this comment.
@hxu65 this is an error report, this can be left in, also dont comment stuff
include/common/SQlite.h
Outdated
| @@ -52,6 +58,7 @@ class SQLiteWrapper { | |||
| createAppsTable(); | |||
| createBlobLocationsTable(); | |||
| createVariableMetadataTable(); | |||
| // std::cout << "MDM: table METADATA: " << getpid() << " "<< dbName << std::endl; | |||
There was a problem hiding this comment.
@hxu65 again, either put them around a debug if def or remove, dont keep coments
include/common/VariableMetadata.h
Outdated
| order = GetCount; | ||
| GetCount++; | ||
| GetMap[name].push_back(GetCount); | ||
| } |
There was a problem hiding this comment.
@hxu65 big comment herer, please delete
include/common/VariableMetadata.h
Outdated
| #include "globalVariable.h" | ||
|
|
||
| //____________Hua_______________ | ||
| // this the variable metadata structure, it can collect the variable metadata information |
There was a problem hiding this comment.
@hxu65 clear the grammar, and remove the name
| @@ -44,13 +44,29 @@ struct ConstructTask : public CreateTaskStateTask { | |||
| : CreateTaskStateTask(alloc, task_node, domain_id, state_name, | |||
| "coeus_mdm", id, queue_info) { | |||
| // Custom params | |||
| // std::cout << "Constructor path: " << db_path << std::endl; | |||
| @@ -94,6 +110,7 @@ struct Mdm_insertTask : public Task, TaskFlags<TF_LOCAL> { | |||
| const TaskStateId &state_id, | |||
| const DbOperation &db_op) : Task(alloc) { | |||
| // Initialize task | |||
| //std::cout << "MDM: task insertion creation" << std::endl; | |||
tasks/coeus_mdm/src/coeus_mdm.cc
Outdated
| db = std::make_unique<SQLiteWrapper>(task->db_path_->str()); | ||
|
|
||
| //std::cout << "MDM: mdm task constructor: " << task->db_path_->str() << std::endl; |
tasks/coeus_mdm/src/coeus_mdm.cc
Outdated
| db->UpdateTotalSteps(db_op.uid, db_op.currentStep); | ||
| //std::cout << "MDM: Hermes update MDM done " << std::endl; |
| add_subdirectory(io_comp) | ||
| add_subdirectory(operator_comp) | ||
| #add_subdirectory(io_comp) | ||
| #add_subdirectory(operator_comp) |
There was a problem hiding this comment.
@hxu65 why is this commented out?
There was a problem hiding this comment.
io_comp and operator_comp cause adios2 undefined function error occasionally, commenting them out can solve this issue.
There was a problem hiding this comment.
can you document this in an issue
| add_subdirectory(io_comp) | ||
| add_subdirectory(operator_comp) | ||
| #add_subdirectory(io_comp) | ||
| #add_subdirectory(operator_comp) |
There was a problem hiding this comment.
can you document this in an issue
No description provided.