Spotless formatting #366
Spotless formatting #366
Conversation
| @@ -1,470 +1,511 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"> | |||
| <modelVersion>4.0.0</modelVersion> | |||
There was a problem hiding this comment.
why do you want to change the default tabulation configuration of IntelliJ and Visual Studio Code (tabulation = 4 characters) ?
For me, your modification is a personal modification and I think we have to keep standard IntelliJ / Visual Studio Code format rules to be homogeneous.
| <plugins> | ||
| <plugin> | ||
| <groupId>com.diffplug.spotless</groupId> | ||
| <artifactId>spotless-maven-plugin</artifactId> |
There was a problem hiding this comment.
is this plugin what updated the formatting ?
| } |
There was a problem hiding this comment.
why do you delete this end line ? It seemed to me that it was necessary to keep the end line (old discussion with @utarwyn)
There was a problem hiding this comment.
Yes indeed, files should end with an empty line. This is both good practice and a convention in many technologies.
Check more in this discussion: https://stackoverflow.com/a/5813359
dedece35
added
🏗️ refactoring
|
@pbaumard, please check mu comments here : green-code-initiative/creedengo-java#92 |
See green-code-initiative/creedengo-common#56
Since this is just about introducing a common format defined by Spotless, a way to check the PR is:
mvn spotless:apply