Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full height on mobile screens, close #62 #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laurenziello
Copy link

No description provided.

@ArsalaBangash ArsalaBangash linked an issue Oct 26, 2020 that may be closed by this pull request
@ArsalaBangash ArsalaBangash self-requested a review October 26, 2020 09:22
@laurenziello
Copy link
Author

@ArsalaBangash do you have some doubts about changes?

@ArsalaBangash
Copy link
Member

Hi @laurenziello My apologies. I just got around to looking at this :)

When I opened the deploy preview on my phone, this is what I got:

image
image

What's the rationale behind min-100vh?

@laurenziello
Copy link
Author

What's the rationale behind min-100vh?

With height: 100vh you fix the height of the page to be the same of the screen device without any scoll.
With min-height: 100vh the page will have at least the same height of the screen device with scroll if it needs more space

@ArsalaBangash
Copy link
Member

@laurenziello Thank you for the explanation. The changes you made work perfectly on the inspection window, but not on actual devices because of the URL bar. I wonder if there's a way to determine the available space on the screen and set the height accordingly.

@laurenziello
Copy link
Author

@laurenziello
Copy link
Author

@ArsalaBangash just made some changes to fix mobile devices problem. Please check if it works.
Could you please also add a label hacktoberfest-accepted in this pull request as described in this page?

https://hacktoberfest.digitalocean.com/hacktoberfest-update

@ArsalaBangash
Copy link
Member

@laurenziello I made some refactoring changes to our project structure, which is now causing conflicts. I've added the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The app doesn't cover the full height on mobile screens
2 participants