-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix full height on mobile screens, close #62 #75
base: master
Are you sure you want to change the base?
Conversation
@ArsalaBangash do you have some doubts about changes? |
Hi @laurenziello My apologies. I just got around to looking at this :) When I opened the deploy preview on my phone, this is what I got: What's the rationale behind min-100vh? |
What's the rationale behind min-100vh? With height: 100vh you fix the height of the page to be the same of the screen device without any scoll. |
@laurenziello Thank you for the explanation. The changes you made work perfectly on the inspection window, but not on actual devices because of the URL bar. I wonder if there's a way to determine the available space on the screen and set the height accordingly. |
@ArsalaBangash ok, I'll try this trick |
@ArsalaBangash just made some changes to fix mobile devices problem. Please check if it works. |
@laurenziello I made some refactoring changes to our project structure, which is now causing conflicts. I've added the label. |
No description provided.