Add A Warning for Comma Dangles #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are going to hold off on merging this until we can ensure that it wont break existing code. We would like to use a tool like prettier to format existing repositories, but we are (reasonably) worried that it might break some stuff (styled components is likely to not play well). |
stevengrimaldo
approved these changes
May 14, 2018
|
Make this an error instead of a warning and bump the version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose that we start embracing column dangles (also known as trailing commas) in our code.
This allows for much cleaner git diffs and can save us potential errors down the road (alphabetizing lines for example). Check out the diff for this PR to see what I mean...added one line, but it shows as 2 additions and 1 deletion (misleading).
Our transpiler (babel) will strip them out for transpiled code, so we don't need to work about issues with legacy browsers.
We've been trained (or some of us have) to see a trailing comma as bad. However, this is becoming a popular formatting choice by a number of leaders in our space: