Fix headline byline yellow box dark mode text colour #10215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the |
|
Size Change: -11 kB (-1%) Total Size: 744 kB
ℹ️ View Unchanged
|
cemms1
reviewed
Jan 16, 2024
| @@ -36,7 +36,7 @@ const yellowBoxStyles = (format: ArticleFormat) => css` | |||
| box-decoration-break: clone; | |||
|
|
|||
| a { | |||
| color: inherit; | |||
| color: ${schemedPalette('--byline-yellowbox-anchor-colour')}; | |||
There was a problem hiding this comment.
not sure we should call it "yellow box" as the background is --byline-background and this may not always be yellow
There was a problem hiding this comment.
maybe --byline-anchor-text?
There was a problem hiding this comment.
Hmm yes this is interesting. I took inspiration for this from the variable name holding these styles, yellowBoxStyles but agree that's not ideal. I'll refactor that as well.
I think --byline-anchor-text is still a bit broad as we only want these styles applied to bylines that appear "in the box", not to every byline anchor.
There was a problem hiding this comment.
hmm maybe --byline-anchor-text can work well actually! I'll see how it looks
DanielCliftonGuardian
approved these changes
Jan 17, 2024
cemms1
approved these changes
Jan 17, 2024
cemms1
reviewed
Jan 17, 2024
Co-authored-by: Max Duval <max.duval@theguardian.com> Co-authored-by: Charlotte Emms <43961396+cemms1@users.noreply.github.com> Co-authored-by: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
|
Seen on PROD (merged by @georgeblahblah 8 minutes and 53 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Closes #10191
Screenshots